Revert adding settings to OCI image #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
============================================
+ Coverage 43.11% 43.78% +0.67%
Complexity 803 803
============================================
Files 241 275 +34
Lines 8359 13252 +4893
Branches 1345 1347 +2
============================================
+ Hits 3604 5803 +2199
- Misses 4355 6850 +2495
- Partials 400 599 +199 ☔ View full report in Codecov by Sentry. |
matejonnet
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves the
serversblock from the build stage (as we don't need auth for downloads) to the deployment stage (and the deployment stage transparently handles that if ACCESS_TOKEN is set)